improvement: cobras spawn and removal of invalid script

ops..

Update cobra_flask.lua

Lua code format - (Stylua)

data-otservbr-global/lib/core/storages.lua

@@ -3089,7 +3089,6 @@ GlobalStorage = {
 	OberonEventTime = 65009,
 	PrinceDrazzakEventTime = 65010,
 	ScarlettEtzelEventTime = 65011,
-	CobraBastionFlask = 65012,
 	Inquisition = 65013,
 	Yasir = 65014,
 	IceCrack = 65016,

data/libs/core/global_storage.lua

@@ -25,5 +25,6 @@ Global = {
 	Storage = {
 		FamiliarSummonEvent10 = 30054,
 		FamiliarSummonEvent60 = 30055,
+		CobraFlask = 30055,
 	},
 }

data/scripts/actions/items/cobra_flask.lua

@@ -0,0 +1,30 @@
+local applyCobraFlaskEffectOnMonsterSpawn = EventCallback()
+
+applyCobraFlaskEffectOnMonsterSpawn.monsterOnSpawn = function(monster, position)
+	if table.contains({ "cobra scout", "cobra vizier", "cobra assassin" }, monster:getName():lower()) then
+		if Game.getStorageValue(Global.Storage.CobraFlask) >= os.time() then
+			monster:setHealth(monster:getMaxHealth() * 0.75)
+			monster:getPosition():sendMagicEffect(CONST_ME_GREEN_RINGS)
+		else
+			Game.setStorageValue(Global.Storage.CobraFlask, -1)
+		end
+	end
+	return true
+end
+
+applyCobraFlaskEffectOnMonsterSpawn:register()
+
+local cobraFlask = Action()
+
+function cobraFlask.onUse(player, item, fromPosition, target, toPosition, isHotkey)
+	if table.contains({ 31284, 31285, 31286, 31287 }, target:getId()) then
+		target:getPosition():sendMagicEffect(CONST_ME_GREENSMOKE)
+		player:sendTextMessage(MESSAGE_EVENT_ADVANCE, "You carefully pour just a tiny, little, finely dosed... and there goes the whole content of the bottle. Stand back!")
+		item:transform(31297)
+		Game.setStorageValue(Global.Storage.CobraFlask, os.time() + 30 * 60)
+	end
+	return true
+end
+
+cobraFlask:id(31296)
+cobraFlask:register()

data/scripts/eventcallbacks/monster/on_spawn.lua

@@ -1,11 +1,3 @@
-local function handleCobra(monster)
-	if monster:getName():lower() == "cobra scout" or monster:getName():lower() == "cobra vizier" or monster:getName():lower() == "cobra assassin" then
-		if getGlobalStorageValue(GlobalStorage.CobraBastionFlask) >= os.time() then
-			monster:setHealth(monster:getMaxHealth() * 0.75)
-		end
-	end
-end
-
 local function handleIronServantReplica(monster)
 	if monster:getName():lower() ~= "iron servant replica" then
 		return
@@ -39,13 +31,13 @@ function callback.monsterOnSpawn(monster, position)
 	if not monster then
 		return
 	end
+
 	HazardMonster.onSpawn(monster, position)
 
 	if monster:getType():isRewardBoss() then
 		monster:setReward(true)
 	end
 
-	handleCobra(monster)
 	handleIronServantReplica(monster)
 
 	if not monster:getType():canSpawn(position) then