fix: check if bankable is valid player before emitting metric

opentibiabr · Mar 17, 2024 · 0a56230 · 0a56230
1 parent af7126a
commit 0a56230
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/game/bank/bank.cpp b/src/game/bank/bank.cpp
@@ -114,8 +114,10 @@ bool Bank::transferTo(const std::shared_ptr<Bank> destination, uint64_t amount)
 	if (!(debit(amount) && destination->credit(amount))) {
 		return false;
 	}
-	g_metrics().addCounter("balance_increase", amount, { { "player", destination->getBankable()->getPlayer()->getName() }, { "context", "bank_transfer" } });
-	g_metrics().addCounter("balance_decrease", amount, { { "player", getBankable()->getPlayer()->getName() }, { "context", "bank_transfer" } });
+	if (destinationBankable->getPlayer() != nullptr) {
+		g_metrics().addCounter("balance_increase", amount, { { "player", destinationBankable()->getPlayer()->getName() }, { "context", "bank_transfer" } });
+		g_metrics().addCounter("balance_decrease", amount, { { "player", getBankable()->getPlayer()->getName() }, { "context", "bank_transfer" } });
+	}
 	return true;
 }
 
@@ -151,6 +153,8 @@ bool Bank::deposit(const std::shared_ptr<Bank> destination, uint64_t amount) {
 	if (!g_game().removeMoney(bankable->getPlayer(), amount)) {
 		return false;
 	}
-	g_metrics().addCounter("balance_increase", amount, { { "player", bankable->getPlayer()->getName() }, { "context", "bank_deposit" } });
+	if (bankable->getPlayer() != nullptr) {
+		g_metrics().addCounter("balance_decrease", amount, { { "player", bankable->getPlayer()->getName() }, { "context", "bank_deposit" } });
+	}
 	return destination->credit(amount);
 }