Various fixes #314
Various fixes #314
Conversation
| return ( | ||
| <> | ||
| <Global |
There was a problem hiding this comment.
moved to main.scss
There was a problem hiding this comment.
Hm, I slightly prefer it here because this way we only hide the osano cookie link if we're also rendering an alternative method. If the hiding is in the sass, it's possible that we hide it, but then don't render this on some screens
There was a problem hiding this comment.
I should have added another comment for context woops, we moved the manage cookies link into the user name/dropdown thing at the top right, with that being there it's not technically rendered until the dropdown is opened. This way every user should have access to it (ie before the researcher experience doesn't have a footer so the cookie was still rendering)
| /> | ||
| <a href='#' onClick={showOsano}>Manage Cookies</a> | ||
| </> | ||
| <span onClick={showOsano}>Manage Cookies</span> |
There was a problem hiding this comment.
if you want to use a span, this needs to have cursor:hover and also a role="button" for a18y
There was a problem hiding this comment.
@nathanstitt the cursor portion is taken care of by the parent link
<StyledLink to='#'>
<Menu.Item>
<ManageCookiesLink />
</Menu.Item>
</StyledLink>
the result:
Question is, would we still want the role on the span? or would this parent cover that case?
There was a problem hiding this comment.
@nathanstitt the cursor portion is taken care of by the parent link
<StyledLink to='#'>
<Menu.Item>
<ManageCookiesLink />
</Menu.Item>
</StyledLink>
the result:
Question is, would we still want the role on the span? or would this parent cover that case?
There was a problem hiding this comment.
nah, sorry I'd left that comment before I realized it was being used in the menu
| <Box align='center' gap='small' onClick={() => step.backAction?.()}> | ||
| <Icon icon='chevronLeft'></Icon> | ||
| <span>Back</span> | ||
| </Box> | ||
| </Link> : <span></span>} | ||
| </FakeLink> : <span></span>} |
There was a problem hiding this comment.
should add role="link" to the span for screenreader
| return ( | ||
| <> | ||
| <Global |
There was a problem hiding this comment.
Hm, I slightly prefer it here because this way we only hide the osano cookie link if we're also rendering an alternative method. If the hiding is in the sass, it's possible that we hide it, but then don't render this on some screens
Addresses multiple points on this ticket