Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM: POC - Override affinity policy for each GlanceAPI #656

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fmount
Copy link
Contributor

@fmount fmount commented Nov 19, 2024

No description provided.

Copy link
Contributor

openshift-ci bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fmount fmount changed the title DNM: POC - Consume lib-common AffinityOverride and allow to override it for each GlanceAPI DNM: POC - Override affinity policy for each GlanceAPI Nov 19, 2024
@fmount fmount force-pushed the affinity-1 branch 2 times, most recently from e231a3c to 1bc7445 Compare November 19, 2024 14:48
@fmount fmount force-pushed the affinity-1 branch 2 times, most recently from ff5964c to 845c1b3 Compare November 21, 2024 12:26
This patch updates the glance-operator GlanceAPITemplate to consume the
AffinityOverrides struct provided by lib-common.
It contains the minimum amount of parameters required to describe the
StatefulSet PodAffinity and PodAntiaffinity, and these overrides are processed
by the DistributePods function.

Signed-off-by: Francesco Pantano <[email protected]>
Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

@fmount: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/glance-operator-build-deploy-tempest 845c1b3 link true /test glance-operator-build-deploy-tempest
ci/prow/glance-operator-build-deploy-kuttl 845c1b3 link true /test glance-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants