830 : Add limit and metadata version params in v2 settings get end-point #838
Conversation
| Map<String, TreeNode<String, Location>> treeNodeHashMap = null; | ||
|
|
||
| if (StringUtils.isBlank(team) && StringUtils.isBlank(providerId) && StringUtils.isBlank(locationId) | ||
| && StringUtils.isBlank(teamId) && StringUtils.isBlank(team) && StringUtils.isBlank(serverVersion)) { | ||
| && StringUtils.isBlank(teamId) && StringUtils.isBlank(team) && StringUtils.isBlank(serverVersion) | ||
| && StringUtils.isBlank(metadataVersion)) { |
There was a problem hiding this comment.
Wont this break the current functionality StringUtils.isBlank(metadataVersion)?
There was a problem hiding this comment.
This check is to ensure that all parameters can not be null. Hence, added meta version field here as well. @bennsimon
Please let me know if there is anything incorrect.
There was a problem hiding this comment.
This is a new parameter so for the devs that were supplying the other params only it should work. i.e metadataVersion should be optional to not break the implementation for others.
There was a problem hiding this comment.
Yes, metadata_version and limit request params are not required fields. This check is to ensure that all request parameters can not be null, we need to supply at least a single request param from the given list. Thus added the check.
Should I remove validation from here? @bennsimon
Resolves #830