Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

830 : Add metadata_version sequence and column in settings_metadata t… #126

Merged
merged 3 commits into from
May 26, 2021

Conversation

rehammuzzamil
Copy link
Contributor

Copy link
Member

@bennsimon bennsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rehammuzzamil How is update handled? Shouldnt it update the metadata_version for that record.

@rehammuzzamil
Copy link
Contributor Author

@rehammuzzamil How is update handled? Shouldnt it update the metadata_version for that record.

@bennsimon updates are catered on the server-core, whenever a new record is added or an already existing record is updated in the settings_metadata table, an increment is done on the metadata_version column through :
metadata_version = nextVal('core.setting_metadata_version_seq')
It is the same approach as per the server_version.

Please let me know if there is anything incorrect.

@rehammuzzamil rehammuzzamil requested a review from bennsimon May 25, 2021 12:02
…in_settings_metadata_table.sql

Co-authored-by: Benn Simon <[email protected]>
@rehammuzzamil rehammuzzamil merged commit 940b833 into master May 26, 2021
@rehammuzzamil rehammuzzamil deleted the 830-add-metadata-version-column branch May 26, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants