Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable register profile contracts #646

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ekigamba
Copy link
Contributor

No description provided.

- Add the configurable register contract as part of the BaseRegisterContract
- Implement new method in the BaseRegisterActivity
- Add RegisterParams pojo
@coveralls
Copy link

coveralls commented Sep 18, 2020

Coverage Status

Coverage decreased (-0.07%) to 64.365% when pulling 53ba300 on add-configurable-register-profile-contracts into f177cd7 on master.

allan-on
allan-on previously approved these changes Sep 21, 2020
Copy link
Contributor

@allan-on allan-on left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@allan-on
Copy link
Contributor

Closes #665

@allan-on allan-on linked an issue Oct 13, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Core Register reconfigurability
3 participants