Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue268 #273

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Issue268 #273

wants to merge 19 commits into from

Conversation

kaderchowdhury
Copy link
Member

Issue 268 branched from master and merged with Issue158
Issue268: prevented app crash during login due to null login response
Issue158: FTS query improvements

@@ -297,7 +297,7 @@ public LoginResponse isValidRemoteLogin(String userName, String password) {
LoginResponse loginResponse = httpAgent
.urlCanBeAccessWithGivenCredentials(requestURL, userName, password);

if (loginResponse.equals(LoginResponse.SUCCESS)) {
if (loginResponse!=null&&loginResponse.equals(LoginResponse.SUCCESS)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use Android Studio formatter to format this (and other files)

@opensrp opensrp deleted a comment Jul 17, 2019
@opensrp opensrp deleted a comment Jul 17, 2019
@opensrp opensrp deleted a comment Jul 17, 2019
@opensrp opensrp deleted a comment Jul 17, 2019
@opensrp opensrp deleted a comment Jul 17, 2019
@opensrp opensrp deleted a comment Jul 17, 2019
@opensrp opensrp deleted a comment Jul 17, 2019
@opensrp opensrp deleted a comment Jul 17, 2019
@opensrp opensrp deleted a comment Jul 17, 2019
@opensrp opensrp deleted a comment Jul 17, 2019
@opensrp opensrp deleted a comment Jul 17, 2019
@opensrp opensrp deleted a comment Jul 17, 2019
@opensrp opensrp deleted a comment Aug 1, 2019
@opensrp opensrp deleted a comment Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants