IK|SmartRegisterQueryBuilder add condition parameter to toStringFTS method #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keymane
reviewed
Jan 25, 2019
There was a problem hiding this comment.
@kaderchowdhury We have a mainCondition column that we use. Just expose the field as an fts sort field and then update your clause in this mainCondition field.
kaderchowdhury
requested review from
keymane,
raihan-mpower and
ndegwamartin
and removed request for
raihan-mpower and
ndegwamartin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new
method 'toStringFts' in 'SmartRegisterQueryBuilder' class, which takes a condition string and appends it to the main query, right before the sort query. The condition needs to be set at RecyclerViewFragment class from the child class