-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added Client Migration for changing the validation status to Invalid #2109
base: master
Are you sure you want to change the base?
Conversation
opensrp-chw/build.gradle
Outdated
@@ -234,7 +234,7 @@ android { | |||
versionName "1.0.8" | |||
buildConfigField "int", "OPENMRS_UNIQUE_ID_INITIAL_BATCH_SIZE", '10000' | |||
buildConfigField "int", "OPENMRS_UNIQUE_ID_BATCH_SIZE", '10000' | |||
buildConfigField "int", "OPENMRS_UNIQUE_ID_SOURCE", '2' | |||
buildConfigField "int", "OPENMRS_UNIQUE_ID_SOURCE", '1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was not pulling the unique ids from source 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this section is under ba
and not DRC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no this is under DRC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes its under Ba it was originally '1' in BA (master branch) i've updated the correction
@@ -48,6 +48,9 @@ public static void onUpgrade(Context context, SQLiteDatabase db, int oldVersion, | |||
case 12: | |||
upgradeToVersion12(db); | |||
break; | |||
case 13: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make these changes for all the flavours
- DB migrations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ekigamba different flavors use different DB versions for instance ba is at version 23 chad using 15 drc using 13 and so on should i upgrade all the versions to the same value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, we should upgrade all the versions but to different values
changed the target sdk to 31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
versionCode 9 | ||
versionName "1.0.2" | ||
buildConfigField "int", "OPENMRS_UNIQUE_ID_INITIAL_BATCH_SIZE", '10000' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure what's the difference between liberia and LMH
default: | ||
break; | ||
} | ||
upgradeTo++; | ||
} | ||
RepositoryUtils.updateClientValidateStatus(db); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this since it is repetitive
@@ -346,13 +346,13 @@ android { | |||
buildConfigField "String", 'DEFAULT_LOCATION_DEBUG', '"CHA"' | |||
buildConfigField "int", "MAX_CONNECTION_TIMEOUT", '5' | |||
buildConfigField "int", "MAX_READ_TIMEOUT", '5' | |||
buildConfigField "int", "DATABASE_VERSION", '8' | |||
buildConfigField "int", "DATABASE_VERSION", '9' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when(mockPatient.getColumnmaps()).thenReturn(map); | ||
when(map.get(DBConstants.KEY.DOB)).thenReturn(dobString); | ||
AllClientsUtils.goToChildProfile(mockActivity, mockPatient, mockBundle); | ||
verify(mockActivity).startActivity(ArgumentMatchers.any()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly specify the specific activity called in this argument/param
added migration for invalidating the client to trigger a revalidation
issue ref https://github.com/opensrp/support/issues/234