CRVS bug fixes #2067
Merged
CRVS bug fixes #2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, Remove Family Member, Out of Area Death Registration completed.
…tion, Birth Certification, Out Area Child registration implemented and tested.
allan-on
requested changes
Jun 10, 2022
opensrp-chw/src/crvs/assets/json.form/birth_certification_changed.json
Outdated
Show resolved
Hide resolved
| "type": "edit_text", | ||
| "v_regex": { | ||
| "value": "([0-9]{1,4}\\/[0-9]{1,4})", | ||
| "err": "Number must take the format of ##/####" |
There was a problem hiding this comment.
Add the error text/string to the relevant properties files to support translation
| "type": "edit_text", | ||
| "v_max_length": { | ||
| "value": "9", | ||
| "err": "Characters must be less than or equal to 9" |
There was a problem hiding this comment.
Add the error texts to the relevant properties files
| "type": "edit_text", | ||
| "v_regex": { | ||
| "value": "([0-9]{1,4}\\/[0-9]{1,4})", | ||
| "err": "Number must take the format of ##/####" |
There was a problem hiding this comment.
Add the text to the relevant properties files
There was a problem hiding this comment.
Relevance is added
| family_register.step2.highest_edu_level.values[2]=Primary | ||
| family_register.step2.dob.v_required.err=Please enter the date of birth | ||
| family_register.step1.fam_source_income.values[1]=Agriculture, hunting and fishing | ||
| family_register.step1.fam_add_province.values[0]=Bas Uele Province |
There was a problem hiding this comment.
Since these are added to the en properties file, they should also be added to the fr properties file as well
allan-on
reviewed
Jun 17, 2022
| @@ -164,7 +164,6 @@ | |||
| "key": "birth_cert_num", | |||
| "openmrs_entity_parent": "", | |||
| "openmrs_entity": "concept", | |||
| "openmrs_entity_id": "162052AAAAAAAAAAAAAAAAAAAAAAAAAAAAAA", | |||
There was a problem hiding this comment.
Why ws this entity_id removed?
There was a problem hiding this comment.
Relevance is added
# Conflicts: # opensrp-chw/build.gradle
Fixed french translations for out_of_area_child_enrollment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2047
#2048