Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Malaria profile with more than one visit #60

Merged
merged 25 commits into from
Oct 11, 2019
Merged

Malaria profile with more than one visit #60

merged 25 commits into from
Oct 11, 2019

Conversation

whoisladleo
Copy link
Contributor

@whoisladleo whoisladleo commented Sep 13, 2019 •
edited
Loading

#22

manutarus
manutarus reviewed Oct 8, 2019
View reviewed changes
Copy link
Member

@manutarus manutarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ladleo lets avoid testing the setter methods

manutarus
manutarus requested changes Oct 8, 2019
View reviewed changes
Copy link
Member

@manutarus manutarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ladleo lets avoid testing the setter methods, add test to the functions added

@manutarus manutarus requested a review from ndegwamartin October 9, 2019 08:37
@whoisladleo
clean ups
7681cd7
@whoisladleo
Merge remote-tracking branch 'origin/malaria_profile_with_more_than_o…
f0327bb 
…ne_visit' into malaria_profile_with_more_than_one_visit

# Conflicts:
#	opensrp-chw-malaria/src/test/java/org/smartregister/activity/BaseMalariaProfileActivityTest.java
@whoisladleo
test BaseMalariaRegisterFragmentPresenter
66b88c8
@whoisladleo
test BaseMalariaRegisterPresenter
ee37882
@whoisladleo
test BaseMalariaRegisterPresenter
de067db
@whoisladleo
Merge remote-tracking branch 'origin/malaria_profile_with_more_than_o…
50f427a 
…ne_visit' into malaria_profile_with_more_than_one_visit
@whoisladleo
fix build
84fa909
@whoisladleo
Update BaseMalariaRegisterPresenterTest.java
0a8795e
@whoisladleo
more tests for BaseMalariaRegisterPresenter
6422877
@whoisladleo
Merge remote-tracking branch 'origin/malaria_profile_with_more_than_o…
3a5d5df 
…ne_visit' into malaria_profile_with_more_than_one_visit

# Conflicts:
#	opensrp-chw-malaria/src/test/java/org/smartregister/presenter/BaseMalariaRegisterPresenterTest.java
@whoisladleo
trigger coveralls
ff4c5fb
@whoisladleo whoisladleo merged commit e42d588 into master Oct 11, 2019
@whoisladleo whoisladleo deleted the malaria_profile_with_more_than_one_visit branch October 11, 2019 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manutarus manutarus manutarus approved these changes

@ndegwamartin ndegwamartin Awaiting requested review from ndegwamartin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whoisladleo @manutarus