Optibp master merge #916
Open
Optibp master merge #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android 11 and 12 support added issue# 906 fix added #906
issue ref#909
issue ref#909
Issue fix 909
# Conflicts: # build.gradle # opensrp-anc/build.gradle # opensrp-anc/src/main/java/org/smartregister/anc/library/task/AttentionFlagsTask.java # reference-app/build.gradle
junaidwarsivd
requested review from
dubdabasoduba,
SebaMutuku and
hamza-vd
and removed request for
dubdabasoduba,
SebaMutuku and
hamza-vd
SebaMutuku
suggested changes
Nov 4, 2022
| @@ -82,7 +94,13 @@ public boolean isSyncSettings() { | |||
|
|
|||
| @Override | |||
| public SyncFilter getEncryptionParam() { | |||
There was a problem hiding this comment.
Add tests for this method.
There was a problem hiding this comment.
added the test
| @@ -57,7 +62,14 @@ public String getExtraStringSettingsParameters() { | |||
| public String getSyncFilterValue() { | |||
There was a problem hiding this comment.
Update or add tests for this method
There was a problem hiding this comment.
added the test
| @@ -25,7 +25,12 @@ public int getSyncMaxRetries() { | |||
|
|
|||
| @Override | |||
| public SyncFilter getSyncFilterParam() { | |||
There was a problem hiding this comment.
Update the tests for this method.
There was a problem hiding this comment.
added the test
| @@ -31,7 +31,8 @@ | |||
| android:name=".activity.LoginActivity" | |||
| android:screenOrientation="portrait" | |||
| android:theme="@style/AncAppTheme.Login" | |||
| android:windowSoftInputMode="stateAlwaysHidden|adjustResize"> | |||
| android:windowSoftInputMode="stateAlwaysHidden|adjustResize" | |||
There was a problem hiding this comment.
this option is for the keyboard popup it was added to not automatically open the key for the text field which is not focused during the opening of the form
opensrp-anc/build.gradle
Outdated
| @@ -189,7 +192,7 @@ dependencies { | |||
| exclude group: 'org.yaml', module: 'snakeyaml' | |||
| exclude group: 'io.ona.rdt-capture', module: 'lib' | |||
| } | |||
| implementation('org.smartregister:opensrp-client-core:4.3.26-SNAPSHOT@aar') { | |||
| implementation('org.smartregister:opensrp-client-core:6.0.0-BETA3-SNAPSHOT@aar') { | |||
There was a problem hiding this comment.
use 6.0.0-SNAPSHOT for client-core
reference-app/build.gradle
Outdated
| @@ -242,7 +245,7 @@ dependencies { | |||
| exclude group: 'io.ona.rdt-capture', module: 'lib' | |||
| } | |||
|
|
|||
| implementation('org.smartregister:opensrp-client-core:4.3.26-SNAPSHOT@aar') { | |||
| implementation('org.smartregister:opensrp-client-core:6.0.0-BETA3-SNAPSHOT@aar') { | |||
There was a problem hiding this comment.
use 6.0.0-SNAPSHOT for client-core
SebaMutuku
previously approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.