Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable rotation in QuestionnaireActivity #3644

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

FikriMilano
Copy link
Collaborator

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3620

Temporary fix.

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@FikriMilano FikriMilano self-assigned this Dec 4, 2024
@FikriMilano FikriMilano marked this pull request as ready for review December 4, 2024 07:01
@FikriMilano FikriMilano enabled auto-merge December 4, 2024 07:01
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.5%. Comparing base (8ee171a) to head (48f7591).
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3644     +/-   ##
=========================================
+ Coverage     27.3%   27.5%   +0.2%     
- Complexity     787     789      +2     
=========================================
  Files          282     282             
  Lines        14699   14603     -96     
  Branches      2634    2618     -16     
=========================================
+ Hits          4023    4027      +4     
+ Misses       10132   10020    -112     
- Partials       544     556     +12     
Flag Coverage Δ
engine 63.7% <ø> (-0.2%) ⬇️
geowidget 16.0% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@Rkareko
Copy link
Contributor

Rkareko commented Dec 4, 2024

@FikriMilano will the long term fix for allowing rotation be tracked under #3620 ?

@FikriMilano FikriMilano added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit 996914e Dec 4, 2024
5 checks passed
@FikriMilano FikriMilano deleted the 3620-disable-rotation-for-forms branch December 4, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form is not visible after screen rotation
3 participants