Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace filters with RES_ID with GET #3561

Closed
wants to merge 4 commits into from
Closed

Conversation

LZRS
Copy link
Contributor

@LZRS LZRS commented Oct 16, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

General FhirEngine#GET method seems to perform much better than doing a search with filter for _id. Filter with _id seems to generate a query with a join to the TokenIndexEntity table that's not very performant

TODO

  • [] Attach data

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@LZRS LZRS self-assigned this Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 26.9%. Comparing base (aef0fdc) to head (15b6b08).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
...e/quest/ui/questionnaire/QuestionnaireViewModel.kt 0.0% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3561     +/-   ##
=========================================
- Coverage     28.1%   26.9%   -1.3%     
+ Complexity     798     706     -92     
=========================================
  Files          282     278      -4     
  Lines        14495   12831   -1664     
  Branches      2584    2342    -242     
=========================================
- Hits          4084    3459    -625     
+ Misses        9872    8902    -970     
+ Partials       539     470     -69     
Flag Coverage Δ
geowidget 16.0% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...er/fhircore/engine/data/local/DefaultRepository.kt 59.4% <ø> (-5.8%) ⬇️
...rcore/engine/util/extension/FhirEngineExtension.kt 53.8% <ø> (-6.6%) ⬇️
...e/quest/ui/questionnaire/QuestionnaireViewModel.kt 2.0% <0.0%> (-3.0%) ⬇️

... and 81 files with indirect coverage changes

@ellykits
Copy link
Collaborator

Interesting refactor @LZRS Can you share any performance stats especially for the register?

@ellykits ellykits added the DNM DO NOT MERGE label Dec 13, 2024
@qiarie
Copy link
Contributor

qiarie commented Dec 17, 2024

Changes introduced by this PR will be added in a separate PR

@qiarie qiarie closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DNM DO NOT MERGE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants