Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP-Update questionnaire styling #2923

Merged
merged 2 commits into from
Dec 15, 2023
Merged

WIP-Update questionnaire styling #2923

merged 2 commits into from
Dec 15, 2023

Conversation

sharon2719
Copy link
Contributor

@sharon2719 sharon2719 commented Dec 15, 2023

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #2910

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@sharon2719 sharon2719 requested a review from Rkareko December 15, 2023 09:08
@sharon2719
Copy link
Contributor Author

sharon2719 commented Dec 15, 2023

@Rkareko the button is still WIP pending SDK implementation
Screenshot from 2023-12-15 11-23-33

@sharon2719 sharon2719 changed the title Update questionnaire styling WIP-Update questionnaire styling Dec 15, 2023
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #2923 (6a2e010) into main (ad3a737) will increase coverage by 2.4%.
Report is 121 commits behind head on main.
The diff coverage is 65.3%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #2923     +/-   ##
=========================================
+ Coverage     64.5%   66.9%   +2.4%     
- Complexity    1075    1097     +22     
=========================================
  Files          218     223      +5     
  Lines         9635   10435    +800     
  Branches      1897    1923     +26     
=========================================
+ Hits          6218    6985    +767     
+ Misses        2234    2224     -10     
- Partials      1183    1226     +43     
Flag Coverage Δ
engine 70.5% <68.0%> (-2.3%) ⬇️
geowidget 65.5% <33.3%> (+1.1%) ⬆️
quest 64.6% <63.9%> (+5.7%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ngine/configuration/view/CompoundTextProperties.kt 100.0% <ø> (ø)
...gine/configuration/workflow/ApplicationWorkflow.kt 100.0% <100.0%> (ø)
.../fhircore/engine/domain/model/QuestionnaireType.kt 100.0% <100.0%> (ø)
...r/fhircore/engine/domain/model/RoundingStrategy.kt 100.0% <100.0%> (ø)
...martregister/fhircore/engine/sync/AppSyncWorker.kt 100.0% <ø> (ø)
...r/fhircore/engine/task/FhirResourceExpireWorker.kt 100.0% <100.0%> (ø)
...fhircore/engine/task/FhirTaskStatusUpdateWorker.kt 100.0% <100.0%> (ø)
...g/smartregister/fhircore/engine/ui/theme/Colors.kt 100.0% <100.0%> (ø)
...gister/fhircore/engine/util/SharedPreferenceKey.kt 100.0% <100.0%> (ø)
...rcore/engine/util/extension/FhirEngineExtension.kt 80.0% <100.0%> (+2.8%) ⬆️
... and 84 more

... and 28 files with indirect coverage changes

@pld pld merged commit b2ca4bc into main Dec 15, 2023
6 checks passed
@pld pld deleted the styling-updates-to-forms branch December 15, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Styling update to forms
2 participants