Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix main content padding on various screens #2892

Open
3 tasks done
Rkareko opened this issue Nov 29, 2023 · 1 comment · Fixed by #2906
Open
3 tasks done

Fix main content padding on various screens #2892

Rkareko opened this issue Nov 29, 2023 · 1 comment · Fixed by #2906
Assignees

Comments

@Rkareko
Copy link
Contributor

Rkareko commented Nov 29, 2023

Describe the feature request.
Update the implementation for the register, profile and reporting screens to use the padding requirements set out on this issue #2887

Acceptance criteria

  • The bottom padding for the various screens should match the updated designs listed on this issue

Area path
A list of ordered steps in the app on usage of the feature to support anyone testing it e.g. Code reviewer, QA e.g.

  1. Login to the app
  2. Open Navigation bar
  3. Click on Children register
  4. Click on Child profile
  5. Click on Edit profile from menu

Implementation plan (For Engineers)

  • Set bottom padding for list (LazyColumn) used to render views in profile and measure report screens, as well as the row in the register footer to 80.dp if fab configuration exists in profile / register configuration otherwise default to 32.dp
  • The UI to be updated are in MeasureReportListScreen, ProfileScreen and the RegisterFooter composable screens
@ageryck
Copy link
Contributor

ageryck commented Feb 7, 2024

Re-opening this issue to create a PR of the same pointing to 0.2.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants