-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NP-604: Add MicroShift Service of Loadbalancer Type Support #1316
Conversation
cc32112
to
cb801fd
Compare
@pliurh: This pull request references NP-604 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dhellmann @fzdarsky PTAL |
@zaneb @stevekuznetsov PTAL and do a review - we would like to get this closed. Thx Daniel |
After going through enhancement and implementation PR I think we have a pretty good idea working in current scenarios. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's probably wise to start an implementation based on this proposal as it is today, and evolve it to meet any missing needs.
971a823
to
1b0c08f
Compare
Signed-off-by: Peng Liu <[email protected]>
@pliurh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The team has agreed on the implementation in openshift/microshift#1241 and this design doc has been scaled back to describe that work, so this is ready to go. /priority important/soon |
@dhellmann: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you all for the review! |
No description provided.