Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NP-604: Add MicroShift Service of Loadbalancer Type Support #1316

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

pliurh
Copy link
Contributor

@pliurh pliurh commented Jan 13, 2023

No description provided.

@pliurh pliurh changed the title Add MicroShift Service of Loadbalancer Type Support NP-604: Add MicroShift Service of Loadbalancer Type Support Feb 7, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 7, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 7, 2023

@pliurh: This pull request references NP-604 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pliurh
Copy link
Contributor Author

pliurh commented Feb 7, 2023

@dhellmann @fzdarsky PTAL

@DanielFroehlich
Copy link

@zaneb @stevekuznetsov PTAL and do a review - we would like to get this closed. Thx Daniel

@pmtk
Copy link
Member

pmtk commented Feb 22, 2023

After going through enhancement and implementation PR I think we have a pretty good idea working in current scenarios.
Implementation of LB Svc controller is almost free because ovn-k does everything for us already.
I'd say we can proceed with what we have (addressing comments here if needed, reviewing the code PR) and come back next release for details on CNI plugins (maybe keeping in mind possibility of multi-node)?

Copy link
Contributor

@mangelajo mangelajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's probably wise to start an implementation based on this proposal as it is today, and evolve it to meet any missing needs.

@pliurh pliurh force-pushed the lb_service branch 2 times, most recently from 971a823 to 1b0c08f Compare February 28, 2023 06:28
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 2, 2023

@pliurh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dhellmann
Copy link
Contributor

The team has agreed on the implementation in openshift/microshift#1241 and this design doc has been scaled back to describe that work, so this is ready to go.

/priority important/soon
/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 2, 2023

@dhellmann: The label(s) priority/important/soon cannot be applied, because the repository doesn't have them.

In response to this:

The team has agreed on the implementation in openshift/microshift#1241 and this design doc has been scaled back to describe that work, so this is ready to go.

/priority important/soon
/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2023
@dhellmann dhellmann added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Mar 2, 2023
@openshift-merge-robot openshift-merge-robot merged commit 11b900e into openshift:master Mar 2, 2023
@zshi-redhat
Copy link
Contributor

Thank you all for the review!

@dhellmann dhellmann removed the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants