Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MON-4118: chore: use alertmanager v2 in tests as v1 is not longer supported in Prometheus 3 #2544

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

machine424
Copy link
Contributor

chore: adjust AdditionalAlertmanagerConfig.[*].APIVersion documentation as v1 is not longer suporter in Prom 3

chore: add a config validation check in case v1 in still using in one of the three AdditionalAlertmanagerConfig (Platform
Prom, UWM Prom and Thanos ruler), this is temp and just meant to guide users during the first 4.X upgrade that ships Prom 3

MON-4118: chore: use alertmanager v2 in tests as v1 is not longer supported in Prometheus 3

This will be mentioned in the release notes and maybe we'll upgrade a "known risk/ a warning" for ->4.19 upgrades.

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

…on as v1 is not longer suporter in Prom 3

chore: add a config validation check in case v1 in still using in one of the three AdditionalAlertmanagerConfig (Platform
Prom, UWM Prom and Thanos ruler), this is temp and just meant to guide users during the first 4.X upgrade that ships Prom 3
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 23, 2024

@machine424: This pull request references MON-4118 which is a valid jira issue.

In response to this:

chore: adjust AdditionalAlertmanagerConfig.[*].APIVersion documentation as v1 is not longer suporter in Prom 3

chore: add a config validation check in case v1 in still using in one of the three AdditionalAlertmanagerConfig (Platform
Prom, UWM Prom and Thanos ruler), this is temp and just meant to guide users during the first 4.X upgrade that ships Prom 3

MON-4118: chore: use alertmanager v2 in tests as v1 is not longer supported in Prometheus 3


This will be mentioned in the release notes and maybe we'll upgrade a "known risk/ a warning" for ->4.19 upgrades.

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 23, 2024
Copy link
Contributor

openshift-ci bot commented Dec 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: machine424

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2024
@machine424
Copy link
Contributor Author

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Dec 23, 2024
@juzhao
Copy link
Contributor

juzhao commented Dec 24, 2024

/retest-required

@juzhao
Copy link
Contributor

juzhao commented Dec 24, 2024

Copy link
Contributor

openshift-ci bot commented Dec 24, 2024

@machine424: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn bf456b9 link false /test okd-scos-e2e-aws-ovn
ci/prow/versions bf456b9 link false /test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@machine424
Copy link
Contributor Author

FYI, from https://github.com/prometheus/alertmanager/releases/tag/v0.27.0 v1 API is removed since v0.27.0, PR: prometheus/alertmanager#2970, not 0.28.0 mentioned in error message: https://github.com/prometheus/alertmanager/pull/2970/files#diff-389f215b8a627266f6eac5be37ea5a33ffe5d39968407f3b2b057f281333c9b1R58 v0.28.0-rc.0 fixes APIv1 deprecation notice, see https://github.com/prometheus/alertmanager/releases/tag/v0.28.0-rc.0, PR: prometheus/alertmanager#3815

Thanks.
On our side we're only mentioning 0.16.0 where v2 was introduced.

@machine424
Copy link
Contributor Author

/retest-required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants