-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-16808: Ensure that spoke BMH is marked as PoweredOn #7097
base: master
Are you sure you want to change the base?
Conversation
@paul-maidment: This pull request references MGMT-16808 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: paul-maidment The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When a new node is added to a Day 2 cluster via a BMH, the resulting BMH is copied to the spoke cluster. Presently, the spoke cluster will always show this with a status of 'poweredOn: false' when the BMH should have a status of 'poweredOn: true'. This PR changes that by forcing a status update in the `ensureSpokeBMH` As the SpokeBMH is not managed (or even reconciled in any way) by Metal3 then it is acceptable for us to manage the status when copying the BMH to the node.
0ac832f
to
9553594
Compare
When a new node is added to a Day 2 cluster via a BMH, the resulting BMH is copied to the spoke cluster. Presently, the spoke cluster will always show this with a status of 'poweredOn: false' when the BMH should have a status of 'poweredOn: true'.
This PR changes that by forcing a status update in the
ensureSpokeBMH
As the SpokeBMH is not managed (or even reconciled in any way) by Metal3 then it is acceptable for us to manage the status when copying the BMH to the node.List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs
, README, etc)Reviewers Checklist