generate-from: make sure we take the type into account #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Filter things we pull by the type. Prior to this, the type specified in the command-line would be ignore. Signed-off-by: Vincent Demeester <[email protected]>
So that we *always* use `X.Y.Z` version scheme, no matter how it is tagged from the repositories we pull. Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
fix-generate-from-with-type
branch
from
90f10ea to
af08d98
Compare
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter things we pull by the type. Prior to this, the type specified
in the command-line would be ignore.
Signed-off-by: Vincent Demeester [email protected]