Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TKNECO-90] Document How to Setup the Catalog #47

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

Aneesh-M-Bhat
Copy link
Contributor

@Aneesh-M-Bhat Aneesh-M-Bhat commented Sep 21, 2023

WIP PR, Currently, It contains an usage example using Tekton Resolvers, need to add another using PAC, PTAL on the current progress

@Aneesh-M-Bhat Aneesh-M-Bhat changed the title Update README.md [TKNECO-90] Document How to Setup the Catalog Sep 21, 2023
Copy link

@Senjuti256 Senjuti256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Senjuti256 Senjuti256 added lgtm and removed lgtm labels Sep 21, 2023
README.md Show resolved Hide resolved
Copy link
Contributor

@otaviof otaviof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress! I've added a few things to changes, please consider.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Aneesh-M-Bhat Aneesh-M-Bhat requested a review from otaviof October 4, 2023 05:40
@otaviof
Copy link
Contributor

otaviof commented Oct 16, 2023

/lgtm

Let's continue to work on this text, that's a good step forward 👍

@openshift-ci openshift-ci bot added the lgtm label Oct 16, 2023
@otaviof
Copy link
Contributor

otaviof commented Oct 16, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Aneesh-M-Bhat, otaviof

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 8881e0a into main Oct 16, 2023
3 checks passed
@otaviof otaviof deleted the Aneesh-M-Bhat-documentation branch October 27, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants