Add e2e test for GCS #85
Conversation
khrm
force-pushed
the
e2eGCS
branch
2 times, most recently
from
7b80f74 to
712a53f
Compare
|
@vdemeester Should I write this in Go or is bash fine? |
khrm
force-pushed
the
e2eGCS
branch
9 times, most recently
from
e5c2cc6 to
2424f49
Compare
| value: $(workspaces.cred.path)/config | ||
| - name: googleCredentialsPath | ||
| value: $(workspaces.cred.path)/creds.json | ||
| - name: validate-cache |
There was a problem hiding this comment.
@PuneetPunamiya See this. In this step, we validate cache. In the previous step, we fetched catch in a different workspace - test.
|
@vdemeester Is it fine if I pull pipelines repo to write tests? |
|
@khrm it depends in what you pull it for 🤭 if it is for 2 functions we can duplicate them here 🤭 |
|
@vdemeester Basically, we would need the pipelinerun client to check status. In script, I am using kubectl in bash. |
khrm
force-pushed
the
e2eGCS
branch
2 times, most recently
from
320f2c1 to
a3d515b
Compare
This adds an e2e test for GCS using storage emulator by passing env STORAGE_EMULATOR_HOST. Reference: https://cloud.google.com/go/docs/reference/cloud.google.com/go/storage/latest
ah yes, it is fine 👍🏼 |
|
/test tekton-caches-main-cache-on-pull-request |
| @@ -6,8 +6,10 @@ TIMEOUT_UNIT = 20m | |||
| GOFUMPT=gofumpt | |||
|
|
|||
| e2e-coverage: ## run e2e tests with coverage | |||
| @go test -failfast -count=1 -tags=$(E2E_TAG) ./tests -coverpkg=./... -coverprofile /tmp/coverage.out | |||
| tests/e2e.sh | |||
There was a problem hiding this comment.
Might want to rename this "e2e-prepare.sh" or something but it could be done in a follow-up.
This adds an e2e test for GCS using storage emulator by passing env STORAGE_EMULATOR_HOST. Reference:
https://cloud.google.com/go/docs/reference/cloud.google.com/go/storage/latest