Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds unit tests for fetch and upload for OCI #61

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Adds unit tests for fetch and upload for OCI #61

merged 2 commits into from
Oct 3, 2024

Conversation

PuneetPunamiya
Copy link
Contributor

@PuneetPunamiya PuneetPunamiya commented Oct 1, 2024 •
edited
Loading

  • Adds unit tests for fetch and upload for OCI

@PuneetPunamiya PuneetPunamiya force-pushed the adds-unit-test-for-fetch-and-upload-oci branch 2 times, most recently from 52c129c to 14fd3cb Compare October 1, 2024 18:03
@vdemeester vdemeester self-requested a review October 3, 2024 06:56
vdemeester
vdemeester requested changes Oct 3, 2024
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We may need to update the workflow(s) to run go test
  • A binary has been commited 🙃

@PuneetPunamiya PuneetPunamiya force-pushed the adds-unit-test-for-fetch-and-upload-oci branch 4 times, most recently from 6ec4a3f to 90e1ed9 Compare October 3, 2024 12:02
@PuneetPunamiya PuneetPunamiya force-pushed the adds-unit-test-for-fetch-and-upload-oci branch from 90e1ed9 to f8759cf Compare October 3, 2024 12:04
@PuneetPunamiya PuneetPunamiya changed the title [WIP] Adds unit tests for fetch and upload for OCI Adds unit tests for fetch and upload for OCI Oct 3, 2024
@vdemeester vdemeester merged commit f6d5940 into openshift-pipelines:main Oct 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PuneetPunamiya @vdemeester