Add Projected volume configuration for Google's WIF #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have added configuration for the Projected volume needed for Google's Workload Identity federation. Here we have assumed that an OIDC is set up in OpenShift/kubernetes which project tokens at the specified path.
khrm
commented
Aug 29, 2024
vdemeester
reviewed
Aug 29, 2024
|
@vdemeester In GCS credentials secret, we pass a json that has a credential source field. This is used by Google library to determine the short lived token path. If I create a second example, won't it have only this volume change? |
Not sure I understand the question, but yes most likely. |
vdemeester
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have added configuration for the Projected volume needed for Google's Workload Identity federation. Here we have assumed that an OIDC is set up in OpenShift/kubernetes which project tokens at the specified path.