Fix file permission issue while doing untar of cache archive #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Dockerfile for konflux adoption * Add shadow-utils and entrypoint * Add rpms * Fix file permission issue while doing untar of cache archive. Remove Entry Point as it is not required. Fix Unit Test so it runs on machines where /root directory is not present. update audience in GCS WIF Pipelinerun
vdemeester
reviewed
Oct 16, 2024
| @@ -28,5 +28,3 @@ LABEL \ | |||
| RUN microdnf install -y shadow-utils | |||
| RUN groupadd -r -g 65532 nonroot && useradd --no-log-init -r -u 65532 -g nonroot nonroot | |||
| USER 65532 | |||
|
|
|||
| ENTRYPOINT ["/ko-app/cache"] | |||
There was a problem hiding this comment.
Why removing the entry point ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Dockerfile for konflux adoption
Add shadow-utils and entrypoint
Add rpms
Fix file permission issue while doing untar of cache archive.
Remove Entry Point as it is not required.
Fix Unit Test so it runs on machines where /root directory is not present.
update audience in GCS WIF Pipelinerun