Add a simple e2e test for the task #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdemeester
force-pushed
the
add-e2e-tests
branch
8 times, most recently
from
401eee7 to
bb58675
Compare
Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
add-e2e-tests
branch
from
bb58675 to
c6961ad
Compare
Signed-off-by: Vincent Demeester <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
|
cc @Senjuti256 |
Senjuti256
reviewed
Nov 23, 2023
Comment on lines
+14
to
+20
| kubectl delete secret regcred || true | ||
| run kubectl create secret generic regcred \ | ||
| --from-file=.dockerconfigjson=$HOME/.docker/config.json \ | ||
| --type=kubernetes.io/dockerconfigjson | ||
| assert_success | ||
| run kubectl patch serviceaccount default -p '{"imagePullSecrets": [{"name": "regcred"}]}' | ||
| assert_success |
There was a problem hiding this comment.
Are we adding this so that we don't face any permission denial issue while accessing the image from registry.redhat.io . Is it because we didn't find any oc image in registry.access.redhat.com ?
There was a problem hiding this comment.
Yes. Some images are not exposed through registry.access.redhat.com so, I went with having some credentials instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vincent Demeester [email protected]