Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the docs for the 'tkn' and 'openshift-client' task, migrated Tasks to v1 and added release.sh file. #20

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

Senjuti256
Copy link
Contributor

Added the docs for the 'tkn' and 'openshift-client' task. Also updated the versions of pipeline required for e2e to v1 version.

Signed off :- Senjuti [email protected]

@openshift-ci openshift-ci bot requested review from otaviof and vdemeester January 4, 2024 07:36
@Senjuti256
Copy link
Contributor Author

@vdemeester

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update the release script to copy those docs as README.md for each tasks, but that can be done in a follow-up.

Copy link

openshift-ci bot commented Jan 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Senjuti256, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 5, 2024
@Senjuti256
Copy link
Contributor Author

Do I need to update the release script to update the docs in README.md in this PR only @vdemeester ?

@Senjuti256
Copy link
Contributor Author

Updated the PR by adding the release script to copy the docs as README.md for each task. @vdemeester

@Senjuti256 Senjuti256 changed the title Added the docs for the 'tkn' and 'openshift-client' task. Added the docs for the 'tkn' and 'openshift-client' task, migrated Tasks to v1 and added release.sh file. Jan 11, 2024
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 16, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 7d393bc into openshift-pipelines:main Jan 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants