Skip to content

Commit

Permalink
Rename images.openshift-cli to openshiftCli
Browse files Browse the repository at this point in the history
The dash `-` in the name is not supported by helm, so we need to
rename it (using camelCase for example)

Signed-off-by: Vincent Demeester <[email protected]>
  • Loading branch information
vdemeester committed Nov 21, 2023
1 parent d84f42c commit af8d3ba
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 23 deletions.
4 changes: 0 additions & 4 deletions scripts/common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,3 @@ function exported_or_fail() {
return 0
}





7 changes: 0 additions & 7 deletions scripts/oc-client.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,3 @@ export KUBECONFIG=$(workspaces.kubeconfig_dir.path)/kubeconfig

"${params.SCRIPT}"








5 changes: 0 additions & 5 deletions scripts/oc-common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,3 @@ exported_or_fail \
WORKSPACES_KUBECONFIG_DIR_PATH \
PARAMS_SCRIPT \
PARAMS_VERSION





8 changes: 2 additions & 6 deletions templates/task-openshift-client.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ spec:
{{- include "load_scripts" ( list . "oc-" ) | nindent 4 }}

- name: oc
image: {{ .Values.images.openshift-cli }}
image: {{ .Values.images.openshiftCli }}
env:
- name: HOME
value: /tekton/home
Expand All @@ -66,12 +66,8 @@ spec:
volumeMounts:
- name: scripts-dir
mountPath: /scripts

volumes:
- name: scripts-dir
emptyDir: {}





2 changes: 1 addition & 1 deletion values.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
images:
bash: registry.access.redhat.com/ubi8-minimal:latest
openshift-cli: registry.redhat.io/openshift3/ose-cli
openshiftCli: registry.redhat.io/openshift3/ose-cli

annotations:
tekton.dev/pipelines.minVersion: "0.17.0"
Expand Down

0 comments on commit af8d3ba

Please sign in to comment.