Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Secret Support #9

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Added Secret Support #9

merged 1 commit into from
Dec 8, 2023

Conversation

Aneesh-M-Bhat
Copy link
Contributor

Solution for Issue#3

@Aneesh-M-Bhat
Copy link
Contributor Author

This PR, I'm basically allowing user to create a secret & pass its name as a parameter to the task, which will then be used to use the values for username & password from the secret created.

vdemeester
vdemeester reviewed Dec 5, 2023
View reviewed changes
test/e2e/e2e.bats Outdated Show resolved Hide resolved
@Aneesh-M-Bhat
Copy link
Contributor Author

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 8, 2023 •
edited
Loading

@Aneesh-M-Bhat: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/osp-112-ocp-414-e2e aea3643 link true /test osp-112-ocp-414-e2e
ci/prow/osp-113-ocp-414-e2e aea3643 link true /test osp-113-ocp-414-e2e
ci/prow/osp-nightly-ocp-414-e2e aea3643 link true /test osp-nightly-ocp-414-e2e
ci/prow/osp-111-ocp-414-e2e aea3643 link true /test osp-111-ocp-414-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vdemeester
Copy link
Member

/retest

@vdemeester
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 8, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Aneesh-M-Bhat, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 8, 2023
@vdemeester vdemeester merged commit 05d6163 into openshift-pipelines:main Dec 8, 2023
8 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester left review comments

Assignees

@vdemeester vdemeester

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aneesh-M-Bhat @vdemeester