Added jib-maven #38
Added jib-maven #38
Conversation
Aneesh-M-Bhat
requested review from
savitaashture
and removed request for
vdemeester and
Senjuti256
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Aneesh-M-Bhat The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Makefile
Outdated
| E2E_MAVEN_PARAMS_PROXY_CONFIGMAP ?= config-proxy-maven | ||
|
|
||
|
|
||
| E2E_JIB_MAVEN_IMAGE ?= docker.io/aneeshmbhat/tekton-maven:latest |
There was a problem hiding this comment.
that is where it gets published changing now.
There was a problem hiding this comment.
its just for test.
There was a problem hiding this comment.
empty docker repo with latest tag for it to get published to
| value: $(context.pipelineRun.name) | ||
| - name: maven-clean | ||
| taskRef: | ||
| name: maven |
There was a problem hiding this comment.
This also we need to use cluster resolver isn't it ??
There was a problem hiding this comment.
we can yes, but not needed necessarily since make install, applys all task in current namespace so it can be directly accessed.
| --param="VERBOSE=true" \ | ||
| --param="IMAGE=${E2E_JIB_MAVEN_IMAGE}" \ | ||
| --workspace="name=source,claimName=task-maven,subPath=source" \ | ||
| --workspace="name=dockerconfig,secret=docker-config" \ |
There was a problem hiding this comment.
where did we create docker-config secret 🤔
There was a problem hiding this comment.
oh ya that was locally when i was testing, changing that.
Aneesh-M-Bhat
force-pushed
the
jib-maven
branch
from
f06d8c1 to
489c467
Compare
|
@Aneesh-M-Bhat: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Added support for jib-maven task.