-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: add tekton results upstream e2e to acceptance test #602
base: main
Are you sure you want to change the base?
Conversation
ab86347
to
497ae82
Compare
/test pipeline-service-test |
c8c48c5
to
b53cf48
Compare
/test pipeline-service-test |
b98c78e
to
eefb194
Compare
Pipeline Service setup is failing 🤔 |
/retest |
@avinal Here are the logs for the latest failure on
|
f9f339f
to
5237336
Compare
value: "$(tasks.tekton-results-fetch-sha.results.tekton-results-downstream-sha)" | ||
workspaces: | ||
- name: source | ||
workspace: tekton-results-source |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@avinal The pipeline-service-test failure is because of workspace
error: the path "/workspace/source/test/e2e/kustomize/rbac.yaml" does not exist
error: failed to create token: serviceaccounts "all-namespaces-read-access" not found
error: failed to create token: serviceaccounts "single-namespace-read-access" not found
you have not cloned the tekton-results
repo into tekton-results-source
workspace. So its not able to find the expected files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me fix that, thanks
5237336
to
b521001
Compare
5c2dcbc
to
8cadc40
Compare
Blocked on #617 and tektoncd/results#437 |
b04cd02
to
300badc
Compare
kubectl create token "$service_account" > "${SA_TOKEN_PATH}"/"$service_account" | ||
done | ||
export API_SERVER_NAME="tekton-results-api-service.tekton-results.svc.cluster.local" | ||
export API_SERVER_ADDR=$(kubectl get route tekton-results -n tekton-results --template='{{.spec.host}}') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add scheme https://
and port 443
. Hope that will solve the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure let me try that.
300badc
to
9ffea73
Compare
/test pipeline-service-test |
2983b08
to
2718c44
Compare
/test pipeline-service-test |
1e57888
to
52f1681
Compare
mkdir -p ${SA_TOKEN_PATH} ${SSL_CERT_PATH} | ||
kubectl get secrets tekton-results-tls -n tekton-results --template='{{index .data "tls.crt"}}' | base64 -d > ${SSL_CERT_PATH}/tekton-results-cert.pem | ||
kubectl get secrets tekton-results-tls -n tekton-results --template='{{index .data "tls.key"}}' | base64 -d > ${SSL_CERT_PATH}/tekton-results-key.pem | ||
oc annotate ingresses.config/cluster ingress.operator.openshift.io/default-enable-http2=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the right place to do this configuration is after this line..
check_clusteroperators |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, should I cancel the current running, or will it run for now?
52f1681
to
c75e639
Compare
c75e639
to
8918fb8
Compare
@avinal Please add a short status to this PR so we know what's blocking it and when we should follow-up. |
- Run tekton results upstream e2e test on sha update in pipeline service - Refer PLNSRVCE-1182 Signed-off-by: Avinal Kumar <[email protected]>
8918fb8
to
10c73a5
Compare
10c73a5
to
8043769
Compare
Signed-off-by: Avinal Kumar [email protected]