Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add tekton results upstream e2e to acceptance test #602

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

avinal
Copy link
Member

@avinal avinal commented Apr 19, 2023

  • Run tekton results upstream e2e test on sha update in pipeline service
  • Refer PLNSRVCE-1182

Signed-off-by: Avinal Kumar [email protected]

@avinal avinal marked this pull request as ready for review April 19, 2023 06:41
@avinal avinal force-pushed the avinal/results-e2e branch 2 times, most recently from ab86347 to 497ae82 Compare April 19, 2023 06:47
@avinal
Copy link
Member Author

avinal commented Apr 19, 2023

/test pipeline-service-test

@avinal avinal force-pushed the avinal/results-e2e branch 12 times, most recently from c8c48c5 to b53cf48 Compare April 19, 2023 11:04
@prietyc123
Copy link
Contributor

/test pipeline-service-test

@avinal avinal force-pushed the avinal/results-e2e branch 3 times, most recently from b98c78e to eefb194 Compare April 19, 2023 11:32
@avinal
Copy link
Member Author

avinal commented Apr 19, 2023

Pipeline Service setup is failing 🤔

@Roming22
Copy link
Contributor

/retest

@Roming22
Copy link
Contributor

@avinal Here are the logs for the latest failure on pipeline-service-test

STEP-EXECUTE-TEKTON-RESULTS-UPSTREAM-E2E

error: failed to create token: serviceaccounts "all-namespaces-read-access" not found
error: failed to create token: serviceaccounts "single-namespace-read-access" not found
=== RUN   TestTaskRun
    e2e_test.go:87: Create: the server could not find the requested resource (post taskruns.tekton.dev)
--- FAIL: TestTaskRun (0.29s)
=== RUN   TestPipelineRun
    e2e_test.go:140: Create: the server could not find the requested resource (post pipelineruns.tekton.dev)
--- FAIL: TestPipelineRun (0.12s)
=== RUN   TestListResults
=== RUN   TestListResults/list_results_under_the_default_parent
    e2e_test.go:181: open /tmp/tekton-results/ssl/tekton-results-cert.pem: no such file or directory
=== RUN   TestListResults/list_results_across_parents
    e2e_test.go:195: open /tmp/tekton-results/ssl/tekton-results-cert.pem: no such file or directory
=== RUN   TestListResults/return_an_error_because_the_identity_isn't_authorized_to_access_all_namespaces
    e2e_test.go:224: open /tmp/tekton-results/ssl/tekton-results-cert.pem: no such file or directory
=== RUN   TestListResults/list_results_under_the_default_parent_using_the_identity_with_more_limited_access
    e2e_test.go:236: open /tmp/tekton-results/ssl/tekton-results-cert.pem: no such file or directory
--- FAIL: TestListResults (0.00s)
    --- FAIL: TestListResults/list_results_under_the_default_parent (0.00s)
    --- FAIL: TestListResults/list_results_across_parents (0.00s)
    --- FAIL: TestListResults/return_an_error_because_the_identity_isn't_authorized_to_access_all_namespaces (0.00s)
    --- FAIL: TestListResults/list_results_under_the_default_parent_using_the_identity_with_more_limited_access (0.00s)
=== RUN   TestListRecords
=== RUN   TestListRecords/list_records_by_omitting_the_result_name
    e2e_test.go:254: open /tmp/tekton-results/ssl/tekton-results-cert.pem: no such file or directory
=== RUN   TestListRecords/list_records_by_omitting_the_parent_and_result_names
    e2e_test.go:268: open /tmp/tekton-results/ssl/tekton-results-cert.pem: no such file or directory
=== RUN   TestListRecords/return_an_error_because_the_identity_isn't_authorized_to_access_all_namespaces
    e2e_test.go:298: open /tmp/tekton-results/ssl/tekton-results-cert.pem: no such file or directory
=== RUN   TestListRecords/list_records_using_the_identity_with_more_limited_access
    e2e_test.go:310: open /tmp/tekton-results/ssl/tekton-results-cert.pem: no such file or directory
--- FAIL: TestListRecords (0.00s)
    --- FAIL: TestListRecords/list_records_by_omitting_the_result_name (0.00s)
    --- FAIL: TestListRecords/list_records_by_omitting_the_parent_and_result_names (0.00s)
    --- FAIL: TestListRecords/return_an_error_because_the_identity_isn't_authorized_to_access_all_namespaces (0.00s)
    --- FAIL: TestListRecords/list_records_using_the_identity_with_more_limited_access (0.00s)
=== RUN   TestGRPCLogging
    e2e_test.go:345: open /tmp/tekton-results/ssl/tekton-results-cert.pem: no such file or directory
--- FAIL: TestGRPCLogging (0.00s)
FAIL
FAIL	github.com/tektoncd/results/test/e2e	0.429s
FAIL

@avinal avinal force-pushed the avinal/results-e2e branch 5 times, most recently from f9f339f to 5237336 Compare April 24, 2023 14:22
value: "$(tasks.tekton-results-fetch-sha.results.tekton-results-downstream-sha)"
workspaces:
- name: source
workspace: tekton-results-source
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avinal The pipeline-service-test failure is because of workspace

error: the path "/workspace/source/test/e2e/kustomize/rbac.yaml" does not exist
error: failed to create token: serviceaccounts "all-namespaces-read-access" not found
error: failed to create token: serviceaccounts "single-namespace-read-access" not found

you have not cloned the tekton-results repo into tekton-results-source workspace. So its not able to find the expected files.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me fix that, thanks

@avinal avinal force-pushed the avinal/results-e2e branch from 5237336 to b521001 Compare April 24, 2023 15:08
@avinal avinal force-pushed the avinal/results-e2e branch 5 times, most recently from 5c2dcbc to 8cadc40 Compare April 25, 2023 11:49
@avinal avinal marked this pull request as draft April 27, 2023 08:22
@avinal
Copy link
Member Author

avinal commented Apr 27, 2023

Blocked on #617 and tektoncd/results#437

@avinal avinal changed the title add tekton results upstream e2e to acceptance test WIP: add tekton results upstream e2e to acceptance test Apr 27, 2023
@avinal avinal force-pushed the avinal/results-e2e branch 6 times, most recently from b04cd02 to 300badc Compare June 12, 2023 12:41
kubectl create token "$service_account" > "${SA_TOKEN_PATH}"/"$service_account"
done
export API_SERVER_NAME="tekton-results-api-service.tekton-results.svc.cluster.local"
export API_SERVER_ADDR=$(kubectl get route tekton-results -n tekton-results --template='{{.spec.host}}')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add scheme https:// and port 443. Hope that will solve the issue.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure let me try that.

@avinal avinal force-pushed the avinal/results-e2e branch from 300badc to 9ffea73 Compare June 12, 2023 16:47
@sayan-biswas
Copy link
Contributor

/test pipeline-service-test

@avinal avinal force-pushed the avinal/results-e2e branch 2 times, most recently from 2983b08 to 2718c44 Compare June 14, 2023 10:42
@avinal
Copy link
Member Author

avinal commented Jun 14, 2023

/test pipeline-service-test

@avinal avinal force-pushed the avinal/results-e2e branch 2 times, most recently from 1e57888 to 52f1681 Compare June 14, 2023 10:54
mkdir -p ${SA_TOKEN_PATH} ${SSL_CERT_PATH}
kubectl get secrets tekton-results-tls -n tekton-results --template='{{index .data "tls.crt"}}' | base64 -d > ${SSL_CERT_PATH}/tekton-results-cert.pem
kubectl get secrets tekton-results-tls -n tekton-results --template='{{index .data "tls.key"}}' | base64 -d > ${SSL_CERT_PATH}/tekton-results-key.pem
oc annotate ingresses.config/cluster ingress.operator.openshift.io/default-enable-http2=true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the right place to do this configuration is after this line..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, should I cancel the current running, or will it run for now?

@avinal avinal force-pushed the avinal/results-e2e branch from 52f1681 to c75e639 Compare June 14, 2023 11:55
@avinal avinal force-pushed the avinal/results-e2e branch from c75e639 to 8918fb8 Compare July 24, 2023 07:24
@Roming22
Copy link
Contributor

Roming22 commented Sep 8, 2023

@avinal Please add a short status to this PR so we know what's blocking it and when we should follow-up.

- Run tekton results upstream e2e test on sha update in pipeline service
- Refer  PLNSRVCE-1182

Signed-off-by: Avinal Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants