Add gateway deployment for Pipelines as Code #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnallapeta
reviewed
Jun 22, 2022
images/gateway/install.sh
Outdated
| } | ||
|
|
||
| install_gateway () { | ||
| KUBECONFIG=${kcp_kcfg} |
There was a problem hiding this comment.
Since you are using KUBECONFIG directly in line 94, this can be removed.
| @@ -39,7 +39,7 @@ prechecks () { | |||
| exit 1 | |||
| fi | |||
|
|
|||
| KCP_ORG=${KCP_WORKSPACE:-} | |||
| KCP_WORKSPACE=${KCP_WORKSPACE:-} | |||
There was a problem hiding this comment.
This file is old. Rebasing should remove this file.
Roming22
reviewed
Jun 22, 2022
|
@bnallapeta @Roming22 anything preventing the merge of this PR? |
bnallapeta
reviewed
Jun 29, 2022
fgiloux
force-pushed
the
gateway
branch
2 times, most recently
from
9529640 to
ce41e3a
Compare
Signed-off-by: Frederic Giloux <[email protected]>
|
@bnallapeta I should have addressed your requets |
bnallapeta
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides the manifest and a workflow for deploying a gateway.
There are however limitations and issues:
These aspects will be addressed in phase 2.
Signed-off-by: Frederic Giloux [email protected]