Skip to content

Commit

Permalink
Merge pull request #892 from miguelsorianod/install-ginkgocli-atproje…
Browse files Browse the repository at this point in the history
…ctlevel

Install and use ginkgo cli at project level
  • Loading branch information
miguelsorianod authored Apr 8, 2024
2 parents f6691b3 + 92f4fb9 commit 9edb954
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/check-pull-request.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,6 @@ jobs:
with:
go-version: ${{ matrix.go }}

- name: Setup Go tools
run: |
go install github.com/onsi/ginkgo/v2/[email protected]
- name: Run the tests
run: make tests ginkgo_flags="--skip-package leadership,retry"

Expand Down
10 changes: 8 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@ goimports_version:=v0.4.0
# machine: the leadership flag and retry tests.
ginkgo_flags:=

.DEFAULT_GOAL := examples

GINKGO := $(LOCAL_BIN_PATH)/ginkgo
ginkgo-install:
@GOBIN=$(LOCAL_BIN_PATH) go install github.com/onsi/ginkgo/v2/[email protected] ;\

.PHONY: examples
examples:
cd examples && \
Expand All @@ -48,8 +54,8 @@ examples:
done

.PHONY: test tests
test tests:
ginkgo run -r $(ginkgo_flags)
test tests: ginkgo-install
$(GINKGO) run -r $(ginkgo_flags)

.PHONY: fmt
fmt:
Expand Down

0 comments on commit 9edb954

Please sign in to comment.