Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "OCM-1534: add backplane_url field in the environment struct."" #848

Merged

Conversation

machi1990
Copy link
Contributor

Reverts #840

We can now go ahead with the change.

Reverting this in preparation for the implementation

/cc @tzvatot

machi1990 added a commit to machi1990/ocm-api-model that referenced this pull request Oct 13, 2023
@machi1990 machi1990 mentioned this pull request Oct 13, 2023
Copy link
Collaborator

@ciaranRoche ciaranRoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ciaranRoche ciaranRoche merged commit dc7deca into openshift-online:main Oct 13, 2023
2 checks passed
@machi1990 machi1990 deleted the revert-840-revert-830-OCM-1534 branch October 13, 2023 12:03
@machi1990
Copy link
Contributor Author

Thanks @ciaranRoche should be ready as well #849

I'll appreciate it if a tag could be created afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants