Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-19344: adding retry to static network apply as it it will fail in ibi case for some period of time and log and error #709

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tsorya
Copy link
Contributor

@tsorya tsorya commented Dec 16, 2024

MGMT-19344: adding retry to static network apply as it it will fail in ibi case for some period of time and log and error

Background / Context

In case we apply static network in ibi flow , it will fail for first time cause of disabled dbus of network manager, service will be restarted and everything will work though it creates confusing error , this change removes it

Issue / Requirement / Reason for change

Solution / Feature Overview

Implementation Details

Other Information

…n ibi case for some period of time and log and error
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 16, 2024

@tsorya: This pull request references MGMT-19344 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

MGMT-19344: adding retry to static network apply as it it will fail in ibi case for some period of time and log and error

Background / Context

In case we apply static network in ibi flow , it will fail for first time cause of disabled dbus of network manager, service will be restarted and everything will work though it creates confusing error , this change removes it

Issue / Requirement / Reason for change

Solution / Feature Overview

Implementation Details

Other Information

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 16, 2024

@tsorya: This pull request references MGMT-19344 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

MGMT-19344: adding retry to static network apply as it it will fail in ibi case for some period of time and log and error

Background / Context

In case we apply static network in ibi flow , it will fail for first time cause of disabled dbus of network manager, service will be restarted and everything will work though it creates confusing error , this change removes it

Issue / Requirement / Reason for change

Solution / Feature Overview

Implementation Details

Other Information

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from donpenney and eranco74 December 16, 2024 07:45
Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from tsorya. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eranco74
Copy link
Collaborator

I think a better a fix is to update the systemd service with After: whatever we require

Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

@tsorya: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ibu-e2e-flow 8c6ab8b link false /test ibu-e2e-flow
ci/prow/ibi-e2e-flow 8c6ab8b link false /test ibi-e2e-flow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants