[WIP] [release-v1.11] Alternative fix for eventtype create-delete loop on built in sources #546
Conversation
Signed-off-by: Pierangelo Di Pilato <[email protected]>
pierDipi
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Pierangelo Di Pilato <[email protected]>
pierDipi
changed the title
| func (r *Reconciler) FinalizeKind(ctx context.Context, source *v1.ApiServerSource) pkgreconciler.Event { | ||
| logging.FromContext(ctx).Info("Deleting source") | ||
| // Allow for eventtypes to be cleaned up | ||
| source.Status.CloudEventAttributes = []duckv1.CloudEventAttributes{} | ||
| return nil | ||
| } |
There was a problem hiding this comment.
@pierDipi I don't quite understand why we are deleting this, would you be able to explain?
There was a problem hiding this comment.
I don't get why we need this knative#7245 (comment)
Signed-off-by: Pierangelo Di Pilato <[email protected]>
|
@pierDipi: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Revert knative#7245 and set the reference namespace if not set to be the EventType namespace