WIP: Get the demo working on OCP4 #30
Conversation
Update registry name and IP for curl command. Still lots of minishift references to remove
| @@ -268,7 +268,8 @@ servicemesh, which is listening on `$(minishift ip):32380`). Stringed together w | |||
| command: | |||
|
|
|||
| ```bash | |||
| $ curl -H "Host: dumpy.myproject.example.com" "http://$(minishift ip):32380/health" | |||
| $ IP=$(oc get -n istio-system service istio-ingressgateway -ojsonpath='{.status.loadBalancer.ingress[0].hostname}') | |||
There was a problem hiding this comment.
Are we guaranteed to have a hostname set here for every OCP4 environment? Usually scripts branch between either ip or hostname (whatever is set).
There was a problem hiding this comment.
I don't know, actually. On the only supported platform (AWS), I expect so. But I agree we can probably do this bettererer
There was a problem hiding this comment.
We should do better! We should get real DNS here and not a host header.
There was a problem hiding this comment.
Easy enough on a shared cloud. I hate to ignore the local cluster peeps, though.
There was a problem hiding this comment.
Well, this issue is about OCP4, so we can assume AWS somewhere for now perhaps?
There was a problem hiding this comment.
An OpenShift Route with dumpy.myproject.<my ocp cluster domain> and an edit to Knative's config-network to change the domain from example.com to <my ocp cluster domain>?
There was a problem hiding this comment.
I think this might be fine getting in as is. We need to find the sequence of commands to make things externally available on OCP4 anyway, we can probably augment that in a subsequent PR if we want to.
* Scale down revision in 60s instead of the default 5m
|
Do we still need this PR? Or do we want to forever keep ocp4 support on a separate branch? |
|
I assumed we would eventually merge it. Once we remove references to minishift and verify it works on some supported OCP4 platform, e.g. AWS |
This prevents smaller OpenShift 4 clusters from running out of CPU just to run this demo. The Knative default is 400m and this cuts that down to 1/8th, or 50m. These pods don't consume any real CPU anyway.
Broker/Trigger usage
Using productized image and its event type
Update registry name and IP for curl command. Still lots of minishift references to remove