Support functional option style API #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnan806
force-pushed
the
polish-func-name
branch
2 times, most recently
from
38e682f to
363d502
Compare
jnan806
changed the title
jnan806
force-pushed
the
polish-func-name
branch
from
669aedf to
c8fdc5e
Compare
jnan806
force-pushed
the
polish-func-name
branch
from
c8fdc5e to
9fca930
Compare
jnan806
force-pushed
the
polish-func-name
branch
from
a4de0ac to
71c7182
Compare
jnan806
changed the title
Support API-Style Options
jnan806
force-pushed
the
polish-func-name
branch
from
71c7182 to
2817d9b
Compare
jnan806
changed the title
|
@sczyh30 PTAL |
|
Also cc @binbin0325 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jiangnan Jia [email protected]
Describe what this PR does / why we need it
2. SDK now lacks a retry mechanism when connect to the transport stream3. invoke chain in the code is too long, need to re-formatDoes this pull request fix one issue?
Fixes #21
Describe how you did it
api, and add param inNewOpenSergoClient2. introduce theretry-gocomponent to realize retry mechanism3. re-format the code by extract func and structDescribe how to verify it
Special notes for reviews