[Backport 2.x] Remove dependency on commons-lang3 #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
Was only used to check for strings being null or empty. We don't need a whole extra library dependency for that (especially since OpenSearch already provides a utility method for that). Signed-off-by: Michael Froh <[email protected]> (cherry picked from commit 7e56847)
Codecov Report
@@ Coverage Diff @@
## 2.x #204 +/- ##
============================================
+ Coverage 83.26% 83.30% +0.03%
- Complexity 334 337 +3
============================================
Files 43 43
Lines 1261 1270 +9
Branches 154 155 +1
============================================
+ Hits 1050 1058 +8
Misses 134 134
- Partials 77 78 +1
|
msfroh
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 7e56847 from #203