Catching AccessDeniedException for Personalize calls #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mishprs
requested review from
msfroh,
macohen,
noCharger,
mingshl and
sejli
as code owners
msfroh
reviewed
Aug 28, 2023
Comment on lines
+106
to
+108
| if (ACCESS_DENIED_EXCEPTION_ERROR_CODE.equals(e.getErrorCode())) { | ||
| throw new InvalidInputException(INSUFFCIENT_PUT_METRIC_PERMISSION_FORMAT); | ||
| } |
There was a problem hiding this comment.
In order for OpenSearch to throw a 4xx error, I believe the thrown exception needs to be something that OpenSearch will recognize as a user input problem, like IllegalArgumentException.
OpenSearch doesn't know about AWS service exception classes.
Codecov Report
@@ Coverage Diff @@
## main #195 +/- ##
============================================
- Coverage 83.26% 83.17% -0.10%
Complexity 334 334
============================================
Files 43 43
Lines 1261 1266 +5
Branches 154 155 +1
============================================
+ Hits 1050 1053 +3
- Misses 134 135 +1
- Partials 77 78 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Catching AccessDeniedException for Personalize calls
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.