Add tracer to getTransports #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gagan Juneja <[email protected]>
Gaganjuneja
requested review from
praveensameneni,
khushbr,
ansjcy,
goyamegh,
getsaurabh02,
sbcd90 and
sgup432
as code owners
|
@khushbr Need you help in reviewing this PR- This is breaking change introduced by telemetry instrumentation changes in the OpenSearch. It needs to go in 2.11 please take a look. |
Codecov Report
@@ Coverage Diff @@
## main #556 +/- ##
=========================================
Coverage 69.17% 69.17%
Complexity 371 371
=========================================
Files 45 45
Lines 2696 2696
Branches 172 172
=========================================
Hits 1865 1865
Misses 728 728
Partials 103 103
|
sbcd90
approved these changes
Oct 5, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
Signed-off-by: Gagan Juneja <[email protected]> Co-authored-by: Gagan Juneja <[email protected]> (cherry picked from commit 999c689)
khushbr
pushed a commit
that referenced
this pull request
Oct 5, 2023
Signed-off-by: Gagan Juneja <[email protected]> Co-authored-by: Gagan Juneja <[email protected]> (cherry picked from commit 999c689) Co-authored-by: Gagan Juneja <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Fixing the breaking change - #555
Resolves - #555
Describe the solution you are proposing
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.