Fix build index with special full table name #336
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean Kao <[email protected]>
seankao-az
commented
Jun 28, 2024
| index.build(spark, None) | ||
| } | ||
| // Getting this error means that parsing doesn't fail with unquoted identifier | ||
| assert(error.getMessage().contains("UnresolvedRelation")) |
There was a problem hiding this comment.
instead, try to specifically check it does NOT fail with unquoted identifier
seankao-az
commented
Jun 28, 2024
| @@ -31,22 +32,15 @@ class FlintSparkCoveringIndexSuite extends FlintSuite { | |||
| } | |||
| } | |||
|
|
|||
| test("can build index building job with unique ID column") { | |||
There was a problem hiding this comment.
this test case is added unintentionally in previous pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix build index with special full table name, including special characters in catalog name and database name.
Also fix test suite for it.
Note: removed a test case that was added unintentionally
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.