Added guide for configuring ssl_assert_hostname #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saimedhi
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
Shephalimittal and
florianvazelle
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #694 +/- ##
=======================================
Coverage 72.14% 72.14%
=======================================
Files 89 89
Lines 7945 7945
=======================================
Hits 5732 5732
Misses 2213 2213 ☔ View full report in Codecov by Sentry. |
saimedhi
force-pushed
the
guide/assert_hostname
branch
from
8e3b90c
to
ad3001b
Compare
1 task
|
The existing doc |
In the existing doc, comment says # hostname verification disabled. Therefore ssl_assert_hostname = False is correct.
|
saimedhi
force-pushed
the
guide/assert_hostname
branch
from
0faa0c6
to
1eec4c4
Compare
|
Are integration test failures expected? |
Verified that failing tests aren't related to this PR; they're YAML tests. Currently working on fixing them. |
dblock
previously approved these changes
Mar 12, 2024
Signed-off-by: saimedhi <[email protected]>
saimedhi
force-pushed
the
guide/assert_hostname
branch
from
1eec4c4
to
0005ecf
Compare
dblock
approved these changes
Mar 19, 2024
AbitraryYu
pushed a commit
to AbitraryYu/opensearch-py
that referenced
this pull request
Apr 22, 2024
Signed-off-by: saimedhi <[email protected]> Signed-off-by: AbitraryYu <[email protected]>
dblock
pushed a commit
to dblock/opensearch-py
that referenced
this pull request
Aug 15, 2024
Signed-off-by: saimedhi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added guide for configuring ssl_assert_hostname
Issues Resolved
Relevant to PR
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.