Override put_mapping definition to make index name optional. #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
requested review from
VachaShah,
harshavamsi,
axeoman,
deztructor,
Shephalimittal,
saimedhi and
florianvazelle
as code owners
Codecov Report
@@ Coverage Diff @@
## main #553 +/- ##
=======================================
Coverage 71.09% 71.09%
=======================================
Files 85 85
Lines 7774 7774
=======================================
Hits 5527 5527
Misses 2247 2247
|
dblock
force-pushed
the
patch-api-spec
branch
2 times, most recently
from
00159b7
to
a01e0db
Compare
saimedhi
requested changes
Oct 26, 2023
opensearchpy/client/plugins.py
Outdated
| "Cannot load `{plugin}` directly to OpenSearch. `{plugin}` already exists in OpenSearch. Please use `OpenSearch.plugin.{plugin}` instead.".format( | ||
| plugin=plugin | ||
| ), | ||
| f"Cannot load `{plugin}` directly to AsyncOpenSearch. `{plugin}` already exists in AsyncOpenSearch. Please use `AsyncOpenSearch.plugin.{plugin}` instead.", |
There was a problem hiding this comment.
The generator has replacing AsyncOpenSearch with OpenSearch code, but it's not happening, and I'm not sure why. https://github.com/saimedhi/opensearch-py/blob/main/utils/generate-api.py#L655
dblock
force-pushed
the
patch-api-spec
branch
from
a01e0db
to
89f4ac9
Compare
Signed-off-by: dblock <[email protected]>
dblock
force-pushed
the
patch-api-spec
branch
from
89f4ac9
to
bc6eaec
Compare
saimedhi
approved these changes
Oct 26, 2023
|
@saimedhi please don't hesitate to hit merge if you approve of a PR and it passes (at least from me!) |
roma2023
pushed a commit
to roma2023/opensearch-py
that referenced
this pull request
Dec 28, 2023
…rch-project#553) Signed-off-by: dblock <[email protected]> Signed-off-by: roma2023 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an alternative to patching in code.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.