-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use API generator. #549
Use API generator. #549
Conversation
f011d8c
to
5a045a4
Compare
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
65fe746
to
376d641
Compare
Codecov Report
@@ Coverage Diff @@
## main #549 +/- ##
==========================================
+ Coverage 70.68% 70.81% +0.13%
==========================================
Files 83 85 +2
Lines 7862 7793 -69
==========================================
- Hits 5557 5519 -38
+ Misses 2305 2274 -31
|
Signed-off-by: dblock <[email protected]>
@saimedhi When running the generator we end up with 1 failing test that calls |
Thank you @dblock, for working on this. Can I take it from here? For put_mapping, alternative approach is to use the below code in the generator.
|
Yes of course. I think my version of patching the API definition is a bit more generic :) |
Description
Finishes #434 and #543.
Introduces a way to override API spec.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.