Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guide/snapshots #490

Closed

Conversation

tejaksha
Copy link

Description

Added the code snippets for snapshots using python client

Issues Resolved

This will resolve the issue #406

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #490 (6befbde) into main (c8b04a5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #490   +/-   ##
=======================================
  Coverage   70.92%   70.92%           
=======================================
  Files          81       81           
  Lines        7732     7732           
=======================================
  Hits         5484     5484           
  Misses       2248     2248           

@dblock
Copy link
Member

dblock commented Sep 12, 2023

  • Doc should be linked from README
  • Capitalize Titles Everywhere
  • DCO needs to be signed

Also I'm seeing #486 which may be further along.

@saimedhi saimedhi changed the title Feature/snapshots python Guide/snapshots Sep 12, 2023
@saimedhi
Copy link
Collaborator

Hello @tejaksha,

We appreciate your work on this PR (#490). However, it appears that both PRs (#490 and #486) are addressing snapshot guides. To ensure efficiency and avoid redundancy, we recommend consolidating your contributions into PR #486. Collaborating with @roma2023 can help expedite progress. Please consider closing this PR and following this approach.

Thank you for your understanding and cooperation.

@dblock
Copy link
Member

dblock commented Nov 9, 2023

Looks like #486 is a lot further along, I'm going to close this. Please feel free to finish either.

@dblock dblock closed this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants