Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run unit tests with PHP 8.3 and 8.4 on CI #229

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Run unit tests with PHP 8.3 and 8.4 on CI #229

merged 2 commits into from
Oct 22, 2024

Conversation

TimWolla
Copy link
Contributor

Description

This PR runs composer run unit with PHP 8.3 and 8.4 in CI. Previously only PHP 7.3 - 8.2 were tested.

Issues Resolved

n/a

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@TimWolla
Copy link
Contributor Author

You might also want to consider upgrading the jobs using PHP 8.2 to 8.3.

dblock
dblock requested changes Oct 21, 2024
View reviewed changes
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind taking a look at integration tests? I think it needs something similar to https://github.com/opensearch-project/opensearch-sdk-py/pull/195/files.

Feel free to add a line to CHANGELOG along the lines of "Added support for PHP 8.3 and 8.4".

@dblock
Copy link
Member

dblock commented Oct 21, 2024

You might also want to consider upgrading the jobs using PHP 8.2 to 8.3.

Yes, please do!

@TimWolla TimWolla mentioned this pull request Oct 21, 2024
Merged
@TimWolla
Copy link
Contributor Author

Would you mind taking a look at integration tests? I think it needs something similar to https://github.com/opensearch-project/opensearch-sdk-py/pull/195/files.

Done in #231. I believe it would need approval either way, because I'm touching the action definition, so I might as well do it cleanly in a separate PR.

@TimWolla TimWolla force-pushed the ci-php8.4 branch 2 times, most recently from c903f90 to d2b9d30 Compare October 21, 2024 14:28
dblock pushed a commit that referenced this pull request Oct 21, 2024
@TimWolla
Add --warning-mode none when assembling OpenSearch in CI (#231)
5b9b251 
* Add `--warning-mode none` when assembling OpenSearch in CI

This should hopefully fix the integration test with unreleased OpenSearch
versions, as per:

#229 (review)

Signed-off-by: Tim Düsterhus <[email protected]>

* Build OpenSearch with Temurin 21

The OpenJDK installed by default appears to be:

> JDK Version           : 11 (Eclipse Temurin JDK)

which apparently is too old.

Signed-off-by: Tim Düsterhus <[email protected]>

---------

Signed-off-by: Tim Düsterhus <[email protected]>
@dblock
Copy link
Member

dblock commented Oct 21, 2024

Rebase on top of #231?

@shyim shyim merged commit e2d50d9 into opensearch-project:main Oct 22, 2024
53 checks passed
@shyim
Copy link
Collaborator

shyim commented Oct 22, 2024

thanks!

@TimWolla TimWolla deleted the ci-php8.4 branch October 22, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@harshavamsi harshavamsi Awaiting requested review from harshavamsi harshavamsi is a code owner

@shyim shyim Awaiting requested review from shyim shyim is a code owner

@saimedhi saimedhi Awaiting requested review from saimedhi saimedhi is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TimWolla @dblock @shyim