fix: php 8.4 deprecations #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyim
requested review from
VachaShah,
dblock,
harshavamsi and
saimedhi
as code owners
shyim
force-pushed
the
fix-php-84-deprecations
branch
from
4aa8e2a
to
093076f
Compare
Signed-off-by: Soner Sayakci <[email protected]>
shyim
force-pushed
the
fix-php-84-deprecations
branch
from
093076f
to
cb12740
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
============================================
+ Coverage 22.01% 28.07% +6.06%
- Complexity 2260 2707 +447
============================================
Files 309 377 +68
Lines 9026 11056 +2030
============================================
+ Hits 1987 3104 +1117
- Misses 7039 7952 +913 ☔ View full report in Codecov by Sentry. |
dblock
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix upcoming PHP 8.4 deprecations
Issues Resolved
Closes #224
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.