Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated opensearch-php to reflect the latest OpenSearch API spec #223

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Aug 13, 2024

Updated opensearch-php to reflect the latest OpenSearch API spec
Date: 2024-10-25

@dblock
Copy link
Member

dblock commented Aug 20, 2024

I don't merge all of these to gather more of the API changes together, then merge all at once before a release.

@opensearch-trigger-bot opensearch-trigger-bot bot force-pushed the automated-api-update branch 5 times, most recently from 0fb3270 to 29fa8e1 Compare August 27, 2024 03:35
@dblock
Copy link
Member

dblock commented Aug 27, 2024

Some legit errors that need to be looked at from the generated code.

1) OpenSearch\Tests\Namespaces\MlNamespaceTest::testDeployModel
OpenSearch\Common\Exceptions\RuntimeException: Missing parameter for the endpoint ml.deploy_model

/Users/runner/work/opensearch-php/opensearch-php/src/OpenSearch/Endpoints/Ml/DeployModel.php:32
/Users/runner/work/opensearch-php/opensearch-php/src/OpenSearch/Namespaces/AbstractNamespace.php:63
/Users/runner/work/opensearch-php/opensearch-php/src/OpenSearch/Namespaces/MlNamespace.php:273
/Users/runner/work/opensearch-php/opensearch-php/tests/Namespaces/MachineLearningNamespaceTest.php:[32](https://github.com/opensearch-project/opensearch-php/actions/runs/10571259471/job/29287037384?pr=223#step:5:33)6

2) OpenSearch\Tests\Namespaces\MlNamespaceTest::testUnDeployModel
OpenSearch\Common\Exceptions\RuntimeException: Missing parameter for the endpoint ml.undeploy_model

/Users/runner/work/opensearch-php/opensearch-php/src/OpenSearch/Endpoints/Ml/UndeployModel.php:32
/Users/runner/work/opensearch-php/opensearch-php/src/OpenSearch/Namespaces/AbstractNamespace.php:63
/Users/runner/work/opensearch-php/opensearch-php/src/OpenSearch/Namespaces/MlNamespace.php:420
/Users/runner/work/opensearch-php/opensearch-php/tests/Namespaces/MachineLearningNamespaceTest.php:[34](https://github.com/opensearch-project/opensearch-php/actions/runs/10571259471/job/29287037384?pr=223#step:5:35)6

@opensearch-trigger-bot opensearch-trigger-bot bot force-pushed the automated-api-update branch 5 times, most recently from 78bc5ec to 80acb62 Compare September 4, 2024 03:35
@opensearch-trigger-bot opensearch-trigger-bot bot force-pushed the automated-api-update branch 5 times, most recently from 24b4a69 to a3d8c5d Compare September 11, 2024 03:35
@opensearch-trigger-bot opensearch-trigger-bot bot force-pushed the automated-api-update branch 3 times, most recently from 60d900c to aeaf862 Compare September 14, 2024 03:35
@opensearch-trigger-bot opensearch-trigger-bot bot force-pushed the automated-api-update branch 2 times, most recently from f96d613 to 2e26286 Compare September 25, 2024 03:39
@opensearch-trigger-bot opensearch-trigger-bot bot force-pushed the automated-api-update branch 6 times, most recently from bdfdf0d to c38c6d4 Compare October 6, 2024 03:39
@opensearch-trigger-bot opensearch-trigger-bot bot force-pushed the automated-api-update branch 5 times, most recently from 3dd8291 to 592da44 Compare October 15, 2024 03:38
@opensearch-trigger-bot opensearch-trigger-bot bot force-pushed the automated-api-update branch 5 times, most recently from b340407 to 572708e Compare October 23, 2024 03:38
@dblock dblock mentioned this pull request Oct 23, 2024
3 tasks
@opensearch-trigger-bot opensearch-trigger-bot bot force-pushed the automated-api-update branch 2 times, most recently from caccec0 to c689a4e Compare October 24, 2024 15:49
@dblock
Copy link
Member

dblock commented Oct 25, 2024

The ML namespace changed parameter names, fixed the templates.

@dblock dblock merged commit 2b2d7de into main Oct 25, 2024
99 checks passed
@dblock dblock deleted the automated-api-update branch October 25, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant